Skip to content

feat(objects): add support for billable members #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2021

Conversation

nejch
Copy link
Member

@nejch nejch commented May 14, 2021

Closes #1454

@codecov-commenter
Copy link

codecov-commenter commented May 14, 2021

Codecov Report

Merging #1456 (fb0b083) into master (7824811) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1456      +/-   ##
==========================================
+ Coverage   90.85%   90.89%   +0.03%     
==========================================
  Files          73       73              
  Lines        4037     4051      +14     
==========================================
+ Hits         3668     3682      +14     
  Misses        369      369              
Flag Coverage Δ
cli_func_v4 80.47% <100.00%> (+0.06%) ⬆️
py_func_v4 79.56% <100.00%> (+0.07%) ⬆️
unit 82.00% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/groups.py 82.41% <100.00%> (ø)
gitlab/v4/objects/members.py 100.00% <100.00%> (ø)

@nejch nejch force-pushed the feat/billable-members branch from 7c5a6e9 to ac00155 Compare May 25, 2021 20:58
@nejch
Copy link
Member Author

nejch commented May 25, 2021

@JohnVillalovos just had to rebase after isort. Feel free to merge though if you're ok with this (when it's green) :)

@nejch nejch force-pushed the feat/billable-members branch from ac00155 to fb0b083 Compare May 25, 2021 21:08
@JohnVillalovos JohnVillalovos enabled auto-merge May 25, 2021 21:13
@JohnVillalovos JohnVillalovos merged commit 184b94b into master May 25, 2021
@nejch nejch deleted the feat/billable-members branch May 25, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request : billable membership functionality
3 participants