Skip to content

chore: correct a type-hint #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2021
Merged

chore: correct a type-hint #1480

merged 1 commit into from
May 29, 2021

Conversation

JohnVillalovos
Copy link
Member

No description provided.

@JohnVillalovos JohnVillalovos requested a review from nejch May 28, 2021 14:27
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2021

Codecov Report

Merging #1480 (5924916) into master (90ecf2f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1480   +/-   ##
=======================================
  Coverage   90.91%   90.91%           
=======================================
  Files          73       73           
  Lines        4051     4052    +1     
=======================================
+ Hits         3683     3684    +1     
  Misses        368      368           
Flag Coverage Δ
cli_func_v4 80.47% <100.00%> (+<0.01%) ⬆️
py_func_v4 79.78% <100.00%> (+<0.01%) ⬆️
unit 82.00% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/cli.py 86.20% <100.00%> (+0.11%) ⬆️

Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Wasn't sure what to do with the module there yeah. One day I'll read up more on typing :D

@nejch nejch merged commit 8eb911d into python-gitlab:master May 29, 2021
@JohnVillalovos JohnVillalovos deleted the jlvillal/fix_hint branch May 29, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants