chore: use built-in function issubclass() instead of getmro() #1481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1481 +/- ##
==========================================
- Coverage 90.91% 90.91% -0.01%
==========================================
Files 73 73
Lines 4051 4049 -2
==========================================
- Hits 3683 3681 -2
Misses 368 368
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Code was using inspect.getmro() to replicate the functionality of the built-in function issubclass() Switch to using issubclass()
nejch
reviewed
May 29, 2021
nejch
approved these changes
May 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code was using inspect.getmro() to replicate the functionality of the
built-in function issubclass()
Switch to using issubclass()