Skip to content

chore: add type-hints to gitlab/v4/cli.py #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2021
Merged

chore: add type-hints to gitlab/v4/cli.py #1483

merged 1 commit into from
Jun 1, 2021

Conversation

JohnVillalovos
Copy link
Member

  • Add type-hints to gitlab/v4/cli.py
  • Add required type-hints to other files based on adding type-hints
    to gitlab/v4/cli.py

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2021

Codecov Report

Merging #1483 (2673af0) into master (fbbc0d4) will decrease coverage by 0.02%.
The diff coverage is 95.74%.

@@            Coverage Diff             @@
##           master    #1483      +/-   ##
==========================================
- Coverage   90.98%   90.95%   -0.03%     
==========================================
  Files          73       73              
  Lines        4080     4090      +10     
==========================================
+ Hits         3712     3720       +8     
- Misses        368      370       +2     
Flag Coverage Δ
cli_func_v4 80.61% <95.74%> (-0.01%) ⬇️
py_func_v4 79.77% <0.00%> (-0.20%) ⬇️
unit 81.98% <46.80%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/cli.py 81.13% <95.74%> (-0.05%) ⬇️

@JohnVillalovos JohnVillalovos requested a review from nejch May 30, 2021 00:32
  * Add type-hints to gitlab/v4/cli.py
  * Add required type-hints to other files based on adding type-hints
    to gitlab/v4/cli.py
Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one question :)

@nejch nejch merged commit 55ae61a into python-gitlab:master Jun 1, 2021
@JohnVillalovos JohnVillalovos deleted the jlvillal/mypy_cli branch January 4, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants