fix: raise error if there is a 301/302 redirection #1486
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1486 +/- ##
==========================================
- Coverage 91.18% 82.66% -8.53%
==========================================
Files 74 74
Lines 4188 4188
==========================================
- Hits 3819 3462 -357
- Misses 369 726 +357
Flags with carried forward coverage won't be shown. Click here to find out more.
|
3.0.0 is fine for me. Earlier is also fine for me. |
|
@nejch Is there anything else that needs to be done for this to get merged? |
Actually no @JohnVillalovos this was ready but I had this idea of getting a bunch of things into 3.0.0 🤣 Let's just do it. Could you just rebase & amend the commit message to have a breaking change trailer for semantic-release? |
How do I do that? I'm not sure what goes in the message to indicate a breaking change. Thanks. |
Sure! Here are some examples https://www.conventionalcommits.org/en/v1.0.0/#examples Actually, maybe it's easier to just amend the title as |
Before we raised an error if there was a 301, 302 redirect but only
from an http URL to an https URL. But we didn't raise an error for
any other redirects.
This caused two problems:
1. PUT requests that are redirected get changed to GET requests
which don't perform the desired action but raise no error. This
is because the GET response succeeds but since it wasn't a PUT it
doesn't update. See issue:
#1432
2. POST requests that are redirected also got changed to GET
requests. They also caused hard to debug tracebacks for the user.
See issue:
#1477
Correct this by always raising a RedirectError exception and improve
the exception message to let them know what was redirected.
Closes: #1485
Closes: #1432
Closes: #1477
Done! Thanks. |
@max-wittig I believe I resolved all your comments. I marked them as resolved. |
I've also opened an issue to resolve the rest (by using responses instead) |
Before we raised an error if there was a 301, 302 redirect but only
from an http URL to an https URL. But we didn't raise an error for
any other redirects.
This caused two problems:
which don't perform the desired action but raise no error. This
is because the GET response succeeds but since it wasn't a PUT it
doesn't update. See issue:
Changing milestone of issue does not work #1432
requests. They also caused hard to debug tracebacks for the user.
See issue:
Not possible to create note in issue #1477
Correct this by always raising a RedirectError exception and improve
the exception message to let them know what was redirected.
Closes: #1485
Closes: #1432
Closes: #1477