Skip to content

fix: functional project service test #1500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 9, 2021
Merged

fix: functional project service test #1500

merged 3 commits into from
Jun 9, 2021

Conversation

JohnVillalovos
Copy link
Member

@JohnVillalovos JohnVillalovos commented Jun 4, 2021 •
edited
Loading 

The PR: https://github.com/python-gitlab/python-gitlab/pull/1462 was
not able to merge due to a change in the latest version of Gitlab.

More details here:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/61646

Update the functional test to first create the project service before
doing a get.

Also bring in the two commits from #1462

@JohnVillalovos
fix: functional project service test
e691762 
The PR: #1462 was
not able to merge due to a change in the latest version of Gitlab.

More details here:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/61646

Update the functional test to first create the project service before
doing a get.
@JohnVillalovos JohnVillalovos requested a review from nejch June 4, 2021 00:40
@JohnVillalovos
Copy link
Member Author

@benjamb Since you pointed out the issue, I wanted to bring this to your attention.

@codecov-commenter
Copy link

Codecov Report

Merging #1500 (e6182ab) into master (d3fac50) will decrease coverage by 8.87%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1500      +/-   ##
==========================================
- Coverage   91.04%   82.17%   -8.88%     
==========================================
  Files          74       74              
  Lines        4145     4145              
==========================================
- Hits         3774     3406     -368     
- Misses        371      739     +368
Flag Coverage Δ
cli_func_v4 ?
py_func_v4 ?
unit 82.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/cli.py 40.37% <0.00%> (-41.14%) ⬇️
gitlab/v4/objects/files.py 52.94% <0.00%> (-39.71%) ⬇️
gitlab/v4/objects/milestones.py 71.42% <0.00%> (-28.58%) ⬇️
gitlab/v4/objects/labels.py 65.21% <0.00%> (-28.27%) ⬇️
gitlab/cli.py 60.34% <0.00%> (-25.87%) ⬇️
gitlab/v4/objects/tags.py 63.88% <0.00%> (-25.00%) ⬇️
gitlab/utils.py 65.51% <0.00%> (-24.14%) ⬇️
gitlab/v4/objects/repositories.py 57.62% <0.00%> (-23.73%) ⬇️
gitlab/v4/objects/settings.py 73.68% <0.00%> (-21.06%) ⬇️
gitlab/v4/objects/sidekiq.py 80.95% <0.00%> (-19.05%) ⬇️
... and 16 more

@benjamb
Copy link
Contributor

benjamb commented Jun 4, 2021

@JohnVillalovos Nice one, thanks!

@JohnVillalovos JohnVillalovos requested a review from max-wittig June 4, 2021 13:41
@nejch nejch merged commit 093db9d into python-gitlab:master Jun 9, 2021
@JohnVillalovos JohnVillalovos deleted the jlvillal/func_project branch January 4, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nejch nejch Awaiting requested review from nejch

@max-wittig max-wittig Awaiting requested review from max-wittig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JohnVillalovos @codecov-commenter @benjamb @nejch