Skip to content

chore: add new required type packages for mypy #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2021
Merged

chore: add new required type packages for mypy #1505

merged 1 commit into from
Jun 13, 2021

Conversation

JohnVillalovos
Copy link
Member

@JohnVillalovos JohnVillalovos commented Jun 8, 2021 •
edited
Loading

New version of mypy flagged errors for missing types. Install the
recommended type-* packages that resolve the issues.

PR #1504 will fail until this is merged.

@JohnVillalovos
chore: add new required type packages for mypy
a7371e1 
New version of mypy flagged errors for missing types. Install the
recommended type-* packages that resolve the issues.
@max-wittig
Copy link
Member

Interesting thing. Seems like that's kind of a mess. So every package has to kinda publish another package with types-*?

@nejch
Copy link
Member

nejch commented Jun 9, 2021

Interesting thing. Seems like that's kind of a mess. So every package has to kinda publish another package with types-*?

These types-* are actually all from the typeshed repo but packaged separately (only released when the specific change). mypy used to bundle all the non-stdlib typing but changed this for some reason. It seems like mypy can take care of this itself with an --install-types flag, but maybe tracking versions is better

@JohnVillalovos
Copy link
Member Author

Other projects are having to do the same thing. Example: https://gitlab.com/cki-project/cki-lib/-/merge_requests/278

nejch
nejch approved these changes Jun 13, 2021
View reviewed changes
Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess since we will never have many dependencies for the package itself this shouldn't get out of control and renovate should keep it tidy for us at least for now.

@nejch nejch merged commit 5446423 into python-gitlab:master Jun 13, 2021
@JohnVillalovos JohnVillalovos deleted the jlvillal/mypy-deps branch June 13, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nejch nejch nejch approved these changes

@max-wittig max-wittig Awaiting requested review from max-wittig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohnVillalovos @max-wittig @nejch