Skip to content

Support Release edition API #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 26, 2021
Merged

Support Release edition API #1522

merged 5 commits into from
Jun 26, 2021

Conversation

PPaques
Copy link
Contributor

@PPaques PPaques commented Jun 15, 2021 •
edited
Loading

Following #1521:

  • Removal of the documentation for deprecated API
  • Support the PUT function of the release API
  • Add documentation
  • unit-test + integration test (well, I've tried)

Closes #1521

@PPaques PPaques mentioned this pull request Jun 15, 2021
Closed
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2021 •
edited
Loading

Codecov Report

Merging #1522 (13bf61d) into master (2c86003) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1522   +/-   ##
=======================================
  Coverage   91.13%   91.13%           
=======================================
  Files          74       74           
  Lines        4162     4163    +1     
=======================================
+ Hits         3793     3794    +1     
  Misses        369      369
Flag Coverage Δ
cli_func_v4 80.73% <100.00%> (+<0.01%) ⬆️
py_func_v4 80.03% <100.00%> (+<0.01%) ⬆️
unit 82.29% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/releases.py 100.00% <100.00%> (ø)

@nejch
Copy link
Member

nejch commented Jun 16, 2021

Thanks a lot @PPaques, could you please run tox -e black to format the code, and change your commit messages to use test type instead of tests :) a quick git rebase -i <base SHA> should do!

@PPaques PPaques force-pushed the 1521-releases-edit branch from 88b3866 to a553fe0 Compare June 16, 2021 06:58
@PPaques
Copy link
Contributor Author

PPaques commented Jun 16, 2021

Done :)

I had to do a git commit -n for unit-test and integration parts.

The pre-commit hook mypymypy was complaining a lot about tests/functional/api/test_releases.py:*: error: Function is missing a type annotation

@PPaques PPaques force-pushed the 1521-releases-edit branch 2 times, most recently from dd5b5c6 to d465eaa Compare June 16, 2021 08:03
@PPaques
Copy link
Contributor Author

PPaques commented Jun 16, 2021

The push was just for commit emails and GPG.
I used my work address and GPG which was not linked to GitHub (make it complaining that it wasn't possible to link commits with my account)

nejch
nejch requested changes Jun 25, 2021
View reviewed changes
Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @PPaques! Just a small note on the functional tests, if you could take a look. Sorry for the delay.

@PPaques PPaques marked this pull request as draft June 26, 2021 07:31
@PPaques PPaques force-pushed the 1521-releases-edit branch from d465eaa to 2ec4a05 Compare June 26, 2021 19:06
@PPaques PPaques force-pushed the 1521-releases-edit branch from 2ec4a05 to 13bf61d Compare June 26, 2021 19:16
@PPaques PPaques marked this pull request as ready for review June 26, 2021 19:16
@nejch nejch merged commit 33d3428 into python-gitlab:master Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nejch nejch nejch approved these changes

Assignees

@PPaques PPaques

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate tag.set_release_description and remove it from docs
3 participants
@PPaques @codecov-commenter @nejch