Skip to content

Added merge_base API endpoint support #1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

GerevSec
Copy link

@GerevSec GerevSec commented Aug 26, 2021

Added simple merge_base API endpoint support, based on the repository_compare code.

Closes #1495.

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2021

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.12%. Comparing base (e54832a) to head (1730fcb).
Report is 1411 commits behind head on main.

Files with missing lines Patch % Lines
gitlab/v4/objects/repositories.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1577      +/-   ##
==========================================
- Coverage   91.16%   91.12%   -0.04%     
==========================================
  Files          74       74              
  Lines        4177     4182       +5     
==========================================
+ Hits         3808     3811       +3     
- Misses        369      371       +2     
Flag Coverage Δ
cli_func_v4 80.72% <60.00%> (-0.03%) ⬇️
py_func_v4 80.08% <60.00%> (-0.03%) ⬇️
unit 82.28% <60.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
gitlab/v4/objects/repositories.py 79.68% <60.00%> (-1.67%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nejch
Copy link
Member

nejch commented Sep 12, 2021

Hi @GerevSec, thanks a lot for your contribution! We just need a few things to get this green:

  1. git commit --amend your commit message to follow conventional commit, e.g. feat(objects): add merge_base API support
  2. run black to format code properly, e.g. with tox -e black
  3. If possible, could you add some documentation and unit tests? for inspiration, see:

@github-actions
Copy link

github-actions bot commented Jan 8, 2022

This Pull Request (PR) was marked stale because it has been open 90 days with no activity. Please remove the stale label or comment on this PR. Otherwise, it will be closed in 15 days.

@github-actions github-actions bot added the stale label Jan 8, 2022
@github-actions
Copy link

This PR was closed because it has been marked stale for 15 days with no activity. If this PR is still valid, please re-open.

@github-actions github-actions bot closed this Jan 24, 2022
@emadimehrdad
Copy link

@nejch @GerevSec
Hi.
Do you have any plan to develop this feature?

@emadimehrdad
Copy link

Hi @nejch
Would you want me to continue this Pull Request? I think this feature will be useful.

@nejch
Copy link
Member

nejch commented Jun 15, 2022

Thanks for the ping again @emadimehrdad, this one slipped a little bit. Yes, we'll pick it up and add some tests to get this merged :)

@nejch nejch assigned nejch and unassigned GerevSec Jun 15, 2022
@nejch
Copy link
Member

nejch commented Jul 23, 2022

As it is, I don't think we can merge a PR with this change alone - the API expects 2 or more refs (arbitrary number), which need to be supplied as an array. So we'll also need #1699 first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No merge_base API support while GitLab v4 API has.
4 participants