-
Notifications
You must be signed in to change notification settings - Fork 671
Added merge_base API endpoint support #1577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1577 +/- ##
==========================================
- Coverage 91.16% 91.12% -0.04%
==========================================
Files 74 74
Lines 4177 4182 +5
==========================================
+ Hits 3808 3811 +3
- Misses 369 371 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Hi @GerevSec, thanks a lot for your contribution! We just need a few things to get this green:
|
This Pull Request (PR) was marked stale because it has been open 90 days with no activity. Please remove the stale label or comment on this PR. Otherwise, it will be closed in 15 days. |
This PR was closed because it has been marked stale for 15 days with no activity. If this PR is still valid, please re-open. |
Hi @nejch |
Thanks for the ping again @emadimehrdad, this one slipped a little bit. Yes, we'll pick it up and add some tests to get this merged :) |
As it is, I don't think we can merge a PR with this change alone - the API expects 2 or more refs (arbitrary number), which need to be supplied as an array. So we'll also need #1699 first. |
Added simple merge_base API endpoint support, based on the repository_compare code.
Closes #1495.