Skip to content

chore: fix type-check issue shown by new requests-types #1621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2021
Merged

chore: fix type-check issue shown by new requests-types #1621

merged 1 commit into from
Oct 6, 2021

Conversation

JohnVillalovos
Copy link
Member

types-requests==2.25.9 changed a type-hint. Update code to handle this
change.

types-requests==2.25.9 changed a type-hint. Update code to handle this
change.
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2021

Codecov Report

Merging #1621 (0ee9aa4) into master (d97f79d) will increase coverage by 87.78%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1621       +/-   ##
===========================================
+ Coverage        0   87.78%   +87.78%     
===========================================
  Files           0       74       +74     
  Lines           0     4307     +4307     
===========================================
+ Hits            0     3781     +3781     
- Misses          0      526      +526     
Flag Coverage Δ
cli_func_v4 81.70% <ø> (?)
unit 83.51% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/client.py 86.98% <ø> (ø)
gitlab/base.py 89.09% <0.00%> (ø)
gitlab/v4/objects/custom_attributes.py 100.00% <0.00%> (ø)
gitlab/v4/objects/snippets.py 83.72% <0.00%> (ø)
gitlab/v4/objects/project_access_tokens.py 100.00% <0.00%> (ø)
gitlab/v4/objects/clusters.py 85.71% <0.00%> (ø)
gitlab/v4/objects/deploy_keys.py 91.30% <0.00%> (ø)
gitlab/v4/objects/boards.py 100.00% <0.00%> (ø)
gitlab/v4/cli.py 81.20% <0.00%> (ø)
gitlab/v4/objects/badges.py 100.00% <0.00%> (ø)
... and 65 more

@nejch nejch merged commit e93f84b into python-gitlab:master Oct 6, 2021
@JohnVillalovos JohnVillalovos deleted the jlvillal/mypy_dep branch January 4, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants