Skip to content

fix(docs):API delete key example #1638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2021
Merged

fix(docs):API delete key example #1638

merged 1 commit into from
Oct 12, 2021

Conversation

bengaywins
Copy link

Closes #1637

@bengaywins bengaywins changed the title Fix API delete key example fix(docs):API delete key example Oct 12, 2021
@JohnVillalovos
Copy link
Member

The commit message will need to be like:

docs: fix API delete key example

@bengaywins
Copy link
Author

Ah I was trying to make sense of that. Just pushed again with docs: prefix.

@JohnVillalovos
Copy link
Member

Ah I was trying to make sense of that. Just pushed again with docs: prefix.

I think it catches everyone the first time.

I actually do a git log to remind myself of the format 😏

@bengaywins
Copy link
Author

must not be sentence-case, start-case, pascal-case, upper-case

Does this mean that the entire commit message must be all lowercase?

@JohnVillalovos
Copy link
Member

must not be sentence-case, start-case, pascal-case, upper-case

Does this mean that the entire commit message must be all lowercase?

No. Just the first letter after the colon. Try the message I suggested above. I believe that will work.

@bengaywins
Copy link
Author

Awesome just pushed with said commit message.

@bengaywins
Copy link
Author

Also really appreciate the help @JohnVillalovos!

@JohnVillalovos
Copy link
Member

Thanks! LGTM (Looks Good To Me).

@JohnVillalovos JohnVillalovos enabled auto-merge (rebase) October 12, 2021 18:00
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2021

Codecov Report

Merging #1638 (7adab7a) into main (4eb8ec8) will decrease coverage by 3.89%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1638      +/-   ##
==========================================
- Coverage   91.90%   88.01%   -3.90%     
==========================================
  Files          74       74              
  Lines        4287     4287              
==========================================
- Hits         3940     3773     -167     
- Misses        347      514     +167     
Flag Coverage Δ
cli_func_v4 81.89% <ø> (ø)
py_func_v4 ?
unit 83.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/files.py 61.76% <0.00%> (-30.89%) ⬇️
gitlab/v4/objects/milestones.py 71.42% <0.00%> (-28.58%) ⬇️
gitlab/utils.py 65.51% <0.00%> (-24.14%) ⬇️
gitlab/v4/objects/repositories.py 57.62% <0.00%> (-23.73%) ⬇️
gitlab/v4/objects/sidekiq.py 80.95% <0.00%> (-19.05%) ⬇️
gitlab/v4/objects/commits.py 78.87% <0.00%> (-15.50%) ⬇️
gitlab/v4/objects/clusters.py 85.71% <0.00%> (-14.29%) ⬇️
gitlab/v4/objects/snippets.py 83.72% <0.00%> (-13.96%) ⬇️
gitlab/v4/objects/environments.py 88.23% <0.00%> (-11.77%) ⬇️
gitlab/v4/objects/merge_requests.py 76.19% <0.00%> (-9.53%) ⬇️
... and 10 more

@JohnVillalovos JohnVillalovos merged commit b31bb05 into python-gitlab:main Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Documentation bug
3 participants