Codecov Report

Merging #1648 (9af09a2) into main (5a1678f) will decrease coverage by 0.10%.
The diff coverage is 30.00%.

@@            Coverage Diff             @@
##             main    #1648      +/-   ##
==========================================
- Coverage   91.90%   91.80%   -0.11%     
==========================================
  Files          74       74              
  Lines        4287     4331      +44     
==========================================
+ Hits         3940     3976      +36     
- Misses        347      355       +8     

Flags with carried forward coverage won't be shown. Click here to find out more.

Thanks for this @mitar. As this grows (I believe you also added the initial retry flag?), I'm wondering if we should switch to using the https://urllib3.readthedocs.io/en/latest/reference/urllib3.util.html#urllib3.util.Retry utility for this. It might reduce our duplication and even clean up our custom 429 handling.

Would you like to give it a try here? If not we can do this in a follow-up, but it'd be great if we could at least have tests for this so that we can see it still behaves properly later. One example of similar tests is here, I think:
https://github.com/python-gitlab/python-gitlab/blob/master/tests/unit/test_gitlab_http_methods.py#L58-L123

This Pull Request (PR) was marked stale because it has been open 90 days with no activity. Please remove the stale label or comment on this PR. Otherwise, it will be closed in 15 days.

Unstale.

@mitar did you still want to take a look at urllib3's retry class or you want to proceed this way?

@mitar as we're getting more requests on this I'm happy to merge this as is and we can work on the rest later, could you just rebase/resolve conflicts please? 🙇

@mitar Would you mind if someone else took over this pr? Or will you have time to work on this soon?

Hey, sorry, I got busy with other things. I can add anyone to the branch if you wan to rebase/fix conflicts. I will try to do it as well, but I do not know when I will be able to circle back to this.

(But definitely sadly I do not have time to add more tests or to port it to urlib3. I would suggest that this gets merged and then followup work is done to get things further. Also, I have been running this code for some time now and it works great/stable.)

I've rebased @mitar's branch here #1904

Added tests and 52x http response range to retries.

Closing this in favor of #1904, as I see git commit authorship was preserved. Thanks for the work here @mitar.