Skip to content

chore: add type-hints to gitlab/v4/objects/groups.py #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2021
Merged

chore: add type-hints to gitlab/v4/objects/groups.py #1668

merged 1 commit into from
Nov 7, 2021

Conversation

JohnVillalovos
Copy link
Member

@JohnVillalovos JohnVillalovos commented Nov 6, 2021 •
edited
Loading 

 * Add type-hints to gitlab/v4/objects/groups.py
 * Add return value to share() function as GitLab docs show it returns
   a value.
 * Add 'get()' method so that type-checkers will understand that
   getting a group is of type Group.

@JohnVillalovos JohnVillalovos changed the title WIP: Add type-hints to gitlab/v4/objects/groups.py chore: add type-hints to gitlab/v4/objects/groups.py Nov 6, 2021
@JohnVillalovos JohnVillalovos requested a review from nejch November 6, 2021 04:22
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2021 •
edited
Loading

Codecov Report

Merging #1668 (65f2bea) into main (4ab9e92) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1668      +/-   ##
==========================================
+ Coverage   91.99%   92.01%   +0.01%     
==========================================
  Files          75       75              
  Lines        4337     4343       +6     
==========================================
+ Hits         3990     3996       +6     
  Misses        347      347
Flag Coverage Δ
cli_func_v4 81.92% <88.23%> (+<0.01%) ⬆️
py_func_v4 81.18% <100.00%> (+0.02%) ⬆️
unit 83.72% <88.23%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/groups.py 87.78% <100.00%> (+0.58%) ⬆️

nejch
nejch reviewed Nov 6, 2021
View reviewed changes
Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @JohnVillalovos just one little question :)

@JohnVillalovos JohnVillalovos requested a review from nejch November 6, 2021 15:38
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/mypy_groups branch 2 times, most recently from 9cb07b3 to 65f2bea Compare November 6, 2021 18:23
JohnVillalovos
JohnVillalovos commented Nov 6, 2021
View reviewed changes
@JohnVillalovos
chore: add type-hints to gitlab/v4/objects/groups.py
94dcb06 
 * Add type-hints to gitlab/v4/objects/groups.py
 * Have share() function update object attributes.
 * Add 'get()' method so that type-checkers will understand that
   getting a group is of type Group.
@nejch nejch merged commit f3688dc into main Nov 7, 2021
@nejch nejch deleted the jlvillal/mypy_groups branch November 7, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nejch nejch Awaiting requested review from nejch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohnVillalovos @codecov-commenter @nejch