Skip to content

chore: add type-hints to multiple files in gitlab/v4/objects/ #1674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2021

Conversation

JohnVillalovos
Copy link
Member

@JohnVillalovos JohnVillalovos commented Nov 7, 2021

Add and/or check type-hints for the following files
gitlab.v4.objects.access_requests
gitlab.v4.objects.applications
gitlab.v4.objects.broadcast_messages
gitlab.v4.objects.deployments
gitlab.v4.objects.keys
gitlab.v4.objects.merge_trains
gitlab.v4.objects.namespaces
gitlab.v4.objects.pages
gitlab.v4.objects.personal_access_tokens
gitlab.v4.objects.project_access_tokens
gitlab.v4.objects.tags
gitlab.v4.objects.templates
gitlab.v4.objects.triggers

Add a 'get' method with the correct type for Managers derived from
GetMixin.

@JohnVillalovos JohnVillalovos requested a review from nejch November 7, 2021 03:56
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/mypy_small_files_1 branch from cabf613 to 288121d Compare November 7, 2021 03:56
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2021

Codecov Report

Merging #1674 (8b75a77) into main (f3688dc) will decrease coverage by 0.02%.
The diff coverage is 88.23%.

@@            Coverage Diff             @@
##             main    #1674      +/-   ##
==========================================
- Coverage   91.97%   91.95%   -0.03%     
==========================================
  Files          75       75              
  Lines        4351     4364      +13     
==========================================
+ Hits         4002     4013      +11     
- Misses        349      351       +2     
Flag Coverage Δ
cli_func_v4 81.85% <64.70%> (-0.04%) ⬇️
py_func_v4 81.18% <88.23%> (+0.01%) ⬆️
unit 83.63% <76.47%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/namespaces.py 91.66% <66.66%> (-8.34%) ⬇️
gitlab/v4/objects/triggers.py 92.85% <66.66%> (-7.15%) ⬇️
gitlab/v4/objects/broadcast_messages.py 100.00% <100.00%> (ø)
gitlab/v4/objects/keys.py 100.00% <100.00%> (ø)
gitlab/v4/objects/merge_trains.py 100.00% <100.00%> (ø)
gitlab/v4/objects/pages.py 100.00% <100.00%> (ø)

Add and/or check type-hints for the following files
    gitlab.v4.objects.access_requests
    gitlab.v4.objects.applications
    gitlab.v4.objects.broadcast_messages
    gitlab.v4.objects.deployments
    gitlab.v4.objects.keys
    gitlab.v4.objects.merge_trains
    gitlab.v4.objects.namespaces
    gitlab.v4.objects.pages
    gitlab.v4.objects.personal_access_tokens
    gitlab.v4.objects.project_access_tokens
    gitlab.v4.objects.tags
    gitlab.v4.objects.templates
    gitlab.v4.objects.triggers

Add a 'get' method with the correct type for Managers derived from
GetMixin.
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/mypy_small_files_1 branch from 288121d to 8b75a77 Compare November 7, 2021 20:36
@nejch nejch merged commit cf801d8 into main Nov 7, 2021
@nejch nejch deleted the jlvillal/mypy_small_files_1 branch November 7, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants