Skip to content

chore: add type-hints to setup.py and check with mypy #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2021
Merged

chore: add type-hints to setup.py and check with mypy #1683

merged 1 commit into from
Nov 15, 2021

Conversation

JohnVillalovos
Copy link
Member

No description provided.

@JohnVillalovos JohnVillalovos force-pushed the jlvillal/mypy_setup branch 2 times, most recently from 4ab835f to 5d198d9 Compare November 9, 2021 05:08
@JohnVillalovos JohnVillalovos requested a review from nejch November 9, 2021 05:12
@nejch
Copy link
Member

nejch commented Nov 14, 2021

Hehe I guess this won't hurt :) Just got a conflict now, sorry for the delay.

@nejch nejch merged commit a553ee7 into main Nov 15, 2021
@nejch nejch deleted the jlvillal/mypy_setup branch November 15, 2021 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nejch nejch Awaiting requested review from nejch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnVillalovos @nejch