chore: add type-hints to remaining gitlab/v4/objects/*.py files #1695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57cd034 to
bb1a454
Compare
Codecov Report
@@ Coverage Diff @@
## main #1695 +/- ##
==========================================
- Coverage 91.53% 91.46% -0.08%
==========================================
Files 75 75
Lines 4574 4616 +42
==========================================
+ Hits 4187 4222 +35
- Misses 387 394 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nejch
reviewed
Nov 17, 2021
bb1a454 to
fbf2bfe
Compare
1ecb0a6 to
ccd93e3
Compare
cf0049b to
d18987f
Compare
When attempting to add type-hints to the the 'manager' attribute into a RESTObject derived class it would break things. This was because our auto-manager creation code would automatically add the specified annotated manager to the 'manager' attribute. This breaks things. Now check in our auto-manager creation if our attribute is called 'manager'. If so we ignore it.
d18987f to
0c22bd9
Compare
This was
linked to
issues
Nov 22, 2021
Closed
nejch
reviewed
Nov 22, 2021
nejch
reviewed
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug in the auto-manager creation code if we added a type-hint for the
managerattribute.Add type-hints for the remainder of the code base.
Finally! 😊