Skip to content

feat(api): add support for epic notes #1712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2021
Merged

Conversation

StingRayZA
Copy link
Contributor

Added support for notes/emojis/discussions on group epics

(also fixed ProjectSnippetNote to use the correct AwardEmojiManager)

Added support for notes on group epics

Signed-off-by: Raimund Hook <raimund.hook@exfo.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1712 (7f4edb5) into main (3225f2c) will decrease coverage by 0.01%.
The diff coverage is 89.74%.

@@            Coverage Diff             @@
##             main    #1712      +/-   ##
==========================================
- Coverage   91.49%   91.47%   -0.02%     
==========================================
  Files          75       75              
  Lines        4630     4668      +38     
==========================================
+ Hits         4236     4270      +34     
- Misses        394      398       +4     
Flag Coverage Δ
cli_func_v4 80.69% <89.74%> (+0.07%) ⬆️
py_func_v4 80.95% <89.74%> (+0.06%) ⬆️
unit 82.96% <89.74%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/award_emojis.py 89.47% <88.88%> (-0.19%) ⬇️
gitlab/v4/objects/notes.py 94.23% <90.47%> (-1.01%) ⬇️

Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @StingRayZA. Was gonna say it would be cool to have tests but I see we have none for these things plus it's a Premium feature. :)

@nejch nejch merged commit 70b9870 into python-gitlab:main Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants