Skip to content

test(cli): improve basic CLI coverage #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2021
Merged

test(cli): improve basic CLI coverage #1721

merged 2 commits into from
Nov 28, 2021

Conversation

nejch
Copy link
Member

@nejch nejch commented Nov 27, 2021

No description provided.

@nejch nejch force-pushed the test/cli-coverage branch from ccb8344 to 6b892e3 Compare November 27, 2021 20:08
@codecov-commenter
Copy link

Codecov Report

Merging #1721 (6b892e3) into main (70b9870) will increase coverage by 0.52%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1721      +/-   ##
==========================================
+ Coverage   91.49%   92.01%   +0.52%     
==========================================
  Files          75       75              
  Lines        4677     4670       -7     
==========================================
+ Hits         4279     4297      +18     
+ Misses        398      373      -25     
Flag Coverage Δ
cli_func_v4 81.43% <ø> (+0.69%) ⬆️
py_func_v4 81.09% <ø> (+0.09%) ⬆️
unit 83.16% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/cli.py 100.00% <ø> (+13.79%) ⬆️
gitlab/client.py 90.05% <0.00%> (+0.25%) ⬆️
gitlab/config.py 93.67% <0.00%> (+0.63%) ⬆️
gitlab/exceptions.py 100.00% <0.00%> (+0.70%) ⬆️
gitlab/v4/cli.py 82.33% <0.00%> (+1.12%) ⬆️
gitlab/__main__.py 100.00% <0.00%> (+100.00%) ⬆️

@nejch nejch marked this pull request as ready for review November 27, 2021 20:27
Copy link
Member

@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll let you merge when you want to 😊

@nejch nejch enabled auto-merge November 28, 2021 01:14
@nejch nejch merged commit 09a973e into main Nov 28, 2021
@nejch nejch deleted the test/cli-coverage branch November 28, 2021 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants