chore: add initial pylint check #1729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9a9c10a to
ddc24be
Compare
Codecov Report
@@ Coverage Diff @@
## main #1729 +/- ##
==========================================
- Coverage 92.03% 92.03% -0.01%
==========================================
Files 75 75
Lines 4683 4681 -2
==========================================
- Hits 4310 4308 -2
Misses 373 373
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ddc24be to
df93b20
Compare
nejch
reviewed
Dec 7, 2021
df93b20 to
da5f43f
Compare
nejch
reviewed
Dec 7, 2021
de14dea to
5f35250
Compare
nejch
reviewed
Dec 7, 2021
dde09fc to
168d2ab
Compare
Initial pylint check is added. A LONG list of disabled checks is also added. In the future we should work through the list and resolve the errors or disable them on a more granular level.
If .pre-commit-config.yaml or .github/workflows/pre_commit.yml are updated then run pre-commit.
cb61379 to
645ef1f
Compare
https://github.com/pre-commit/mirrors-mypy/blob/master/.pre-commit-hooks.yaml Sets some default args which seem to be interfering with things. Plus we set all of our args in the `pyproject.toml` file.
645ef1f to
b67a6ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial pylint check is added. A LONG list of disabled checks is also
added. In the future we should work through the list and resolve the
errors or disable them on a more granular level.