Skip to content

feat: package file delete on package file object #1733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2021
Merged

feat: package file delete on package file object #1733

merged 1 commit into from
Dec 10, 2021

Conversation

shebertd
Copy link

@shebertd shebertd commented Dec 6, 2021

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2021

Codecov Report

Merging #1733 (124667b) into main (4945353) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1733   +/-   ##
=======================================
  Coverage   91.95%   91.95%           
=======================================
  Files          75       75           
  Lines        4689     4689           
=======================================
  Hits         4312     4312           
  Misses        377      377           
Flag Coverage Δ
cli_func_v4 81.40% <100.00%> (ø)
py_func_v4 80.93% <100.00%> (ø)
unit 83.15% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/packages.py 96.29% <100.00%> (ø)

@JohnVillalovos
Copy link
Member

Thanks. Would you be willing to add a test case for this? Probably in tests/functional/api/test_packages.py would be good.

@shebertd
Copy link
Author

shebertd commented Dec 6, 2021

@JohnVillalovos I will!

@shebertd shebertd changed the title fix package file delete feat: package file delete on package file object Dec 8, 2021
@shebertd
Copy link
Author

shebertd commented Dec 8, 2021

@JohnVillalovos I've added a unit tests and classified the merge as a feat.

@shebertd
Copy link
Author

shebertd commented Dec 9, 2021

@JohnVillalovos I've fixed my test. I like the setup of the project with commitlint.

@JohnVillalovos
Copy link
Member

Thanks. As a note for the future. It can sometimes be simpler to do the tests in the tests/functional/api/ directory as those actually run against a running Gitlab instance.

But thanks for the unit tests!

@shebertd
Copy link
Author

shebertd commented Dec 9, 2021

Thanks for your precious time. I will note that! As a fact I will revisit the functional test in the future to help me learn pytest and be more confident in the delete at the same time.

My delete is'nt a great test because it only test if it does'nt work, but not if it works.

@nejch
Copy link
Member

nejch commented Dec 10, 2021

Thank you very much @simonisateur!

@nejch nejch merged commit 2f37ccb into python-gitlab:main Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants