Skip to content

chore: fix pylint error "expression-not-assigned" #1738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Conversation

JohnVillalovos
Copy link
Member

Fix pylint error "expression-not-assigned" and remove check from the
disabled list.

And I personally think it is much more readable now and is less lines
of code.

Fix pylint error "expression-not-assigned" and remove check from the
disabled list.

And I personally think it is much more readable now and is less lines
of code.
@codecov-commenter
Copy link

Codecov Report

Merging #1738 (a90eb23) into main (3a7d6f6) will decrease coverage by 0.07%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #1738      +/-   ##
==========================================
- Coverage   92.03%   91.95%   -0.08%     
==========================================
  Files          75       75              
  Lines        4681     4689       +8     
==========================================
+ Hits         4308     4312       +4     
- Misses        373      377       +4     
Flag Coverage Δ
cli_func_v4 81.40% <50.00%> (-0.06%) ⬇️
py_func_v4 80.93% <0.00%> (-0.14%) ⬇️
unit 83.15% <50.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/cli.py 81.38% <50.00%> (-0.95%) ⬇️

@nejch nejch merged commit 3679591 into main Dec 8, 2021
@nejch nejch deleted the jlvillal/pylint_fixes branch December 8, 2021 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants