Skip to content

chore: enable using GitLab EE in functional tests #1778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Conversation

JohnVillalovos
Copy link
Member

@JohnVillalovos JohnVillalovos commented Dec 26, 2021

Enable using GitLab Enterprise Edition (EE) in the functional tests.
This will allow us to add tests for EE only features in the
functional tests.

Closes #1492

@JohnVillalovos JohnVillalovos force-pushed the jlvillal/gitlab-ee branch 24 times, most recently from df76c27 to 5bcfe86 Compare December 27, 2021 18:49
@JohnVillalovos JohnVillalovos changed the title wip: testing gitlab-ee chore: enable using GitLab EE in functional tests Dec 27, 2021
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/gitlab-ee branch 2 times, most recently from 98c80f2 to 3ad3496 Compare December 27, 2021 19:50
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/gitlab-ee branch 4 times, most recently from f5ae314 to c819fe8 Compare June 2, 2022 05:21
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/gitlab-ee branch 2 times, most recently from eafcf91 to 1d1e06b Compare June 30, 2022 00:49
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/gitlab-ee branch 2 times, most recently from 00dbf1c to c0095a0 Compare July 4, 2022 20:49
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/gitlab-ee branch 2 times, most recently from 9cfea3c to 3c4432f Compare July 22, 2022 21:02
@JohnVillalovos JohnVillalovos marked this pull request as ready for review July 22, 2022 21:15
@JohnVillalovos JohnVillalovos requested a review from nejch July 22, 2022 21:24
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/gitlab-ee branch 2 times, most recently from 26a2f4d to 6c0c32f Compare July 22, 2022 22:00
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2022

Codecov Report

Merging #1778 (71fd47d) into main (9833632) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1778      +/-   ##
==========================================
+ Coverage   95.42%   95.44%   +0.01%     
==========================================
  Files          79       79              
  Lines        5198     5198              
==========================================
+ Hits         4960     4961       +1     
+ Misses        238      237       -1     
Flag Coverage Δ
api_func_v4 81.41% <ø> (+0.09%) ⬆️
cli_func_v4 83.16% <ø> (+0.38%) ⬆️
unit 87.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/wikis.py 100.00% <0.00%> (+3.44%) ⬆️

@JohnVillalovos JohnVillalovos force-pushed the jlvillal/gitlab-ee branch 2 times, most recently from eec116d to 71fd47d Compare July 23, 2022 17:18
Enable using GitLab Enterprise Edition (EE) in the functional tests.
This will allow us to add functional tests for EE only features in the
functional tests.
@nejch nejch merged commit b661003 into main Jul 26, 2022
@nejch nejch deleted the jlvillal/gitlab-ee branch July 26, 2022 11:25
@nejch
Copy link
Member

nejch commented Jul 26, 2022

@JohnVillalovos fyi I had to re-run this a few times before it went green, maybe just GitHub Actions being weird but might need to increase the timeout a bit - not sure if the EE is a chunkier image and takes longer to boot ;)

@JohnVillalovos
Copy link
Member Author

@nejch I give pre-authorization to revert this if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add project wiki and group wiki tests
3 participants