Skip to content

chore: add logging to tests/functional/conftest.py #1786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2022
Merged

chore: add logging to tests/functional/conftest.py #1786

merged 1 commit into from
Jan 9, 2022

Conversation

JohnVillalovos
Copy link
Member

I have found trying to debug issues in the functional tests can be
difficult. Especially when trying to figure out failures in the CI
running on Github.

Add logging to tests/functional/conftest.py to have a better
understanding of what is happening during a test run which is useful
when trying to troubleshoot issues in the CI.

@JohnVillalovos JohnVillalovos marked this pull request as draft December 30, 2021 05:17
@JohnVillalovos JohnVillalovos marked this pull request as ready for review December 30, 2021 05:42
nejch
nejch reviewed Dec 30, 2021
View reviewed changes
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/logging branch 2 times, most recently from 93967ee to 2dd8fdb Compare December 30, 2021 18:11
@JohnVillalovos JohnVillalovos requested a review from nejch December 30, 2021 19:39
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/logging branch 4 times, most recently from 87b6150 to 5ab8b3f Compare January 4, 2022 05:44
nejch
nejch reviewed Jan 6, 2022
View reviewed changes
Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JohnVillalovos! Just a few comments for discussion from me.

I have found trying to debug issues in the functional tests can be difficult. Especially when trying to figure out failures in the CI running on Github.

Add logging to tests/functional/conftest.py to have a better understanding of what is happening during a test run which is useful when trying to troubleshoot issues in the CI.

Just a note here, I prefer debugging locally as otherwise watchers can get spammed with notifications on many pushes. But I understand sometimes it's CI-only issues and then it's hard to debug so this makes sense.

@JohnVillalovos
Copy link
Member Author

Just a note here, I prefer debugging locally as otherwise watchers can get spammed with notifications on many pushes. But I understand sometimes it's CI-only issues and then it's hard to debug so this makes sense.

I personally have found this quite useful for local debugging too. I like having a progress indication for one. Even though it doesn't give me an ETA at least I know it is doing something.

@JohnVillalovos JohnVillalovos force-pushed the jlvillal/logging branch 2 times, most recently from 089e84a to aa1e458 Compare January 7, 2022 06:51
@JohnVillalovos JohnVillalovos requested a review from nejch January 7, 2022 07:08
@JohnVillalovos
chore: add logging to tests/functional/conftest.py
a1ac9ae 
I have found trying to debug issues in the functional tests can be
difficult. Especially when trying to figure out failures in the CI
running on Github.

Add logging to `tests/functional/conftest.py` to have a better
understanding of what is happening during a test run which is useful
when trying to troubleshoot issues in the CI.
@nejch nejch merged commit ac81272 into main Jan 9, 2022
@nejch nejch deleted the jlvillal/logging branch January 9, 2022 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nejch nejch Awaiting requested review from nejch

Assignees

@JohnVillalovos JohnVillalovos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnVillalovos @nejch