Skip to content

test: drop httmock dependency in test_gitlab.py #1787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2021
Merged

test: drop httmock dependency in test_gitlab.py #1787

merged 1 commit into from
Dec 30, 2021

Conversation

nejch
Copy link
Member

@nejch nejch commented Dec 30, 2021 •
edited
Loading

Explicitly registering the responses inside the test cases ended up actually being a little less verbose than writing dedicated fixtures, and also helps with header cleanup in #1788 as well as reducing the code changes migrating from httmock.

@nejch nejch force-pushed the test/drop-httmock branch from 64890cc to 701ad6b Compare December 30, 2021 13:18
@nejch nejch mentioned this pull request Dec 30, 2021
Merged
@nejch nejch requested a review from JohnVillalovos December 30, 2021 14:37
JohnVillalovos
JohnVillalovos approved these changes Dec 30, 2021
View reviewed changes
Copy link
Member

@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good.

@JohnVillalovos JohnVillalovos merged commit c764bee into main Dec 30, 2021
@JohnVillalovos JohnVillalovos deleted the test/drop-httmock branch December 30, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnVillalovos JohnVillalovos JohnVillalovos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nejch @JohnVillalovos