test: reproduce missing pagination headers in tests #1788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b43927c to
0c92300
Compare
JohnVillalovos
approved these changes
Dec 30, 2021
| @@ -18,6 +18,7 @@ | |||
|
|
|||
| import pickle | |||
| import warnings | |||
| from copy import deepcopy | |||
There was a problem hiding this comment.
nit: My personal taste is import copy and then use copy.deepcopy() as when reading the code quickly know where it comes from.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #1787.
I tried parametrizing tests at first but this seemed cleaner in the end, it would get overly complicated because of pytest-dev/pytest#349.