Skip to content

chore: add a stale workflow #1789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2022
Merged

chore: add a stale workflow #1789

merged 1 commit into from
Jan 7, 2022

Conversation

JohnVillalovos
Copy link
Member

@JohnVillalovos JohnVillalovos commented Dec 31, 2021

Use the stale action to close issues and pull-requests with no
activity.

Issues: It will mark them as stale after 60 days and then close
them once they have been stale for 15 days.

Pull-Requests: It will mark pull-requests as stale after 90 days and then close
them once they have been stale for 15 days.

https://github.com/actions/stale

Closes: #1649

@JohnVillalovos JohnVillalovos requested a review from nejch December 31, 2021 13:43
@nejch
Copy link
Member

nejch commented Jan 2, 2022

I like this a lot! I'm still thinking about my comment from #1649 (comment). I'd limit it to issues and PRs where we're getting stuck because of user inaction, with no clarification - and not those that are confirmed bugs/valid requests but we haven't done anything about them. Does that make sense?

For that we could maybe use only-* or exempt-* with some of our existing labels, or think of something new. We do use awaiting feedback quite a lot, that would be a good candidate for example.

I'd also make it a bit more lenient (maybe 90 days for stale, 15 days to close) in case people are on vacation? Sometimes even I don't respond to an issue within 30 days.. 😸

@JohnVillalovos
Copy link
Member Author

I like this a lot! I'm still thinking about my comment from #1649 (comment). I'd limit it to issues and PRs where we're getting stuck because of user inaction, with no clarification - and not those that are confirmed bugs/valid requests but we haven't done anything about them. Does that make sense?

For that we could maybe use only-* or exempt-* with some of our existing labels, or think of something new. We do use awaiting feedback quite a lot, that would be a good candidate for example.

That could work. Just need to figure out what we want to use. But I would use exempt-* as want this automated not something where we need to tag something before it will get automatically moved to stale.

I'd also make it a bit more lenient (maybe 90 days for stale, 15 days to close) in case people are on vacation? Sometimes even I don't respond to an issue within 30 days.. 😸

90 days! Seems so long 😁 But yeah can do that.

@JohnVillalovos JohnVillalovos force-pushed the jlvillal/stale branch 4 times, most recently from 43f1743 to 0b87e22 Compare January 4, 2022 05:49
Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can go ahead with this with a few labels as suggested above @JohnVillalovos WDYT?

Use the stale action to close issues and pull-requests with no
activity.

Issues: It will mark them as stale after 60 days and then close
them once they have been stale for 15 days.

Pull-Requests: It will mark pull-requests as stale after 90 days and then close
them once they have been stale for 15 days.

https://github.com/actions/stale

Closes: #1649
@nejch nejch merged commit 9896340 into main Jan 7, 2022
@nejch nejch deleted the jlvillal/stale branch January 7, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up an action to lock very old closed issues
3 participants