Codecov Report

Merging #1807 (e42b07e) into main (9894b35) will decrease coverage by 0.08%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #1807      +/-   ##
==========================================
- Coverage   92.02%   91.93%   -0.09%     
==========================================
  Files          76       76              
  Lines        4790     4800      +10     
==========================================
+ Hits         4408     4413       +5     
- Misses        382      387       +5     

Flags with carried forward coverage won't be shown. Click here to find out more.

Thanks for the PR. Can you please squash the commits down to one commit. And make sure there is a commit message.

Also if possible unit and/or functional tests would be great.

Thanks again!

And updating the documentation on how to use it would also be useful.

Note that the typo fix commit is unrelated to the feature commit. Should I remove it?

I looked at the documentation, but it seems to be autogenerated.

There are usage examples for a limited number of group methods in docs/gl_objects/groups.rst. The related group method transfer_project doesn't appear there, so I thought it appropriate not to add transfer_group.

I wasn't able to find tests for the related group method transfer_project. If you add tests for that one, I can base the ones for transfer_group on those.

I wasn't able to find tests for the related group method transfer_project. If you add tests for that one, I can base the ones for transfer_group on those.

I'll try and add some tests for transfer_project as well.
Edit: I think the more equivalent tests would be for transfer_project from here https://github.com/python-gitlab/python-gitlab/blob/main/gitlab/v4/objects/projects.py#L529-L544

I would prefer transfer as well (that's also the name of the API path). Should I change it?

I would prefer transfer as well (that's also the name of the API path). Should I change it?

Yeah, let's do that. This just looks nicer:

group = gl.groups.get("gitlab-org/maintainers")
group.transfer("gitlab-com")

It also avoids us getting into an awkward situation if GitLab comes up with a "transfer a group into this group" endpoint at some point 😅 (as is the case with transfer_project here)

Okay. I have have also renamed the exception from GitlabTransferGroupError to GitlabGroupTransferError.

Thanks, LGTM @sattlerc, not sure if John has any more comments. I'll open an accompanying PR for project transfer and you can rebase after merge if you like, I'll ping here.

not sure if John has any more comments.

Only that tests would be nice. But I think you said you will work on setting up the test framework and then we can land this on top of that.

Hey @sattlerc I'm really sorry for the mixup here, I prepared the environment in #1833 and was then eager to get this one merged, so I rebased and amended the commit to reflect the new method name. But I pushed to your fork too early and github auto-closed the PR so I can't push/reopen anymore :(

We've recreated it here https://github.com/python-gitlab/python-gitlab/pull/1837/files and you remain the author of the feature commit. I hope this is ok with you 🙇

Don't worry about it.