fix: use url-encoded ID in all paths #1819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
720c11a to
598aa08
Compare
Codecov Report
@@ Coverage Diff @@
## main #1819 +/- ##
==========================================
- Coverage 92.19% 92.17% -0.03%
==========================================
Files 77 77
Lines 4819 4843 +24
==========================================
+ Hits 4443 4464 +21
- Misses 376 379 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nejch
requested changes
Jan 9, 2022
JohnVillalovos
added a commit
that referenced
this pull request
Jan 9, 2022
An alternative to #1819 Make sure all usage of the ID in the URL path is encoded. Normally it isn't an issue as most IDs are integers or strings which don't contain a slash ('/'). But when the ID is a string with a slash character it will break things. Add a test case that shows this fixes wikis issue with subpages which use the slash character. Closes: #1079
JohnVillalovos
added a commit
that referenced
this pull request
Jan 9, 2022
An alternative to #1819 Make sure all usage of the ID in the URL path is encoded. Normally it isn't an issue as most IDs are integers or strings which don't contain a slash ('/'). But when the ID is a string with a slash character it will break things. Add a test case that shows this fixes wikis issue with subpages which use the slash character. Closes: #1079
JohnVillalovos
added a commit
that referenced
this pull request
Jan 9, 2022
An alternative to #1819 Make sure all usage of the ID in the URL path is encoded. Normally it isn't an issue as most IDs are integers or strings which don't contain a slash ('/'). But when the ID is a string with a slash character it will break things. Add a test case that shows this fixes wikis issue with subpages which use the slash character. Closes: #1079
JohnVillalovos
added a commit
that referenced
this pull request
Jan 9, 2022
An alternative to #1819 Make sure all usage of the ID in the URL path is encoded. Normally it isn't an issue as most IDs are integers or strings which don't contain a slash ('/'). But when the ID is a string with a slash character it will break things. Add a test case that shows this fixes wikis issue with subpages which use the slash character. Closes: #1079
9b40dda to
54abe80
Compare
nejch
reviewed
Jan 9, 2022
54abe80 to
e6ba4b2
Compare
nejch
reviewed
Jan 9, 2022
nejch
reviewed
Jan 9, 2022
9896154 to
f9fed09
Compare
c865920 to
af3f5ae
Compare
nejch
reviewed
Jan 11, 2022
a5ff3b5 to
826a03f
Compare
nejch
reviewed
Jan 13, 2022
nejch
reviewed
Jan 13, 2022
Make sure all usage of the ID in the URL path is encoded. Normally it
isn't an issue as most IDs are integers or strings which don't contain
a slash ('/'). But when the ID is a string with a slash character it
will break things.
Add a test case that shows this fixes wikis issue with subpages which
use the slash character.
Closes: #1079
Add EncodedId string class. This class returns a URL-encoded string but ensures it will only URL-encode it once even if recursively called. Also added some functional tests of 'lazy' objects to make sure they work.
a3983fc to
2d9612b
Compare
nejch
reviewed
Jan 13, 2022
2d9612b to
10f9ca4
Compare
16f725f to
a05ee47
Compare
nejch
reviewed
Jan 13, 2022
a05ee47 to
25d9125
Compare
nejch
reviewed
Jan 13, 2022
utils.EncodedId() has basically the same functionalityy of using utils._url_encode(). So remove utils._url_encode() as we don't need it.
25d9125 to
b07eece
Compare
nejch
approved these changes
Jan 13, 2022
There was a problem hiding this comment.
Awesome @JohnVillalovos this will fix like 90% of the CLI path issues for sub-resources :)
|
Thanks for all the reviews @nejch Looks a LOT better from where I started 😊 |
This was referenced Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure all usage of the ID in the URL path is encoded. Normally it
isn't an issue as most IDs are integers or strings which don't contain
a slash ('/'). But when the ID is a string with a slash character it
will break things.
Add a test case that shows this fixes wikis issue with subpages which
use the slash character.
Closes: #1079