feat(api): return result from SaveMixin.save()
#1832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nejch
approved these changes
Jan 13, 2022
|
@JohnVillalovos I think we want this in the changelog so maybe even |
4ce0a87 to
675f587
Compare
SaveMixin.save()SaveMixin.save()
Sure! Done. |
|
@kernelport I've marked this as closing #1081 since it implements the rest of your PR. Feel free to reopen the issue if it's not solved after the release. You'll be credited as the author of the commit here. |
fc8cd44 to
d90443c
Compare
Return the new object data when calling `SaveMixin.save()`. Also remove check for `None` value when calling `self.manager.update()` as that method only returns a dictionary. Closes: #1081
d90443c to
e6258a4
Compare
Codecov Report
@@ Coverage Diff @@
## main #1832 +/- ##
=======================================
Coverage 92.20% 92.20%
=======================================
Files 77 77
Lines 4834 4834
=======================================
Hits 4457 4457
Misses 377 377
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return the new object data when calling
SaveMixin.save().Also remove check for
Nonevalue when callingself.manager.update()as that method only returns a dictionary.Closes #1081.