chore: create new ArrayAttribute class #1866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a new ArrayAttribute class. This is to indicate types which are sent to the GitLab server as arrays https://docs.gitlab.com/ee/api/#array At this stage it is identical to the CommaSeparatedListAttribute class but will be used later to support the array types sent to GitLab. This is the second step in a series of steps of our goal to add full support for the GitLab API data types[1]: * array * hash * array of hashes Step one was: commit 5127b15 [1] https://docs.gitlab.com/ee/api/#encoding-api-parameters-of-array-and-hash-types Related: #1698
Codecov Report
@@ Coverage Diff @@
## main #1866 +/- ##
=======================================
Coverage 92.35% 92.35%
=======================================
Files 77 77
Lines 4854 4856 +2
=======================================
+ Hits 4483 4485 +2
Misses 371 371
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nejch
reviewed
Jan 31, 2022
| "iids": types.CommaSeparatedListAttribute, | ||
| "labels": types.CommaSeparatedListAttribute, | ||
| } | ||
| _types = {"iids": types.ArrayAttribute, "labels": types.CommaSeparatedListAttribute} |
There was a problem hiding this comment.
lol, this is infuriating:
https://docs.gitlab.com/ee/api/issues.html#list-issues
GET /issues?iids[]=42&iids[]=43
GET /issues?labels=foo,bar
😁 thanks for going through all the endpoints. I hope the API docs are accurate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new ArrayAttribute class. This is to indicate types which are
sent to the GitLab server as arrays
https://docs.gitlab.com/ee/api/#array
At this stage it is identical to the CommaSeparatedListAttribute class
but will be used later to support the array types sent to GitLab.
This is the second step in a series of steps of our goal to add full
support for the GitLab API data types[1]:
Step one was: commit 5127b15
[1] https://docs.gitlab.com/ee/api/#encoding-api-parameters-of-array-and-hash-types
Related: #1698