chore: correct type-hints for per_page attrbute #1880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1880 +/- ##
==========================================
- Coverage 92.50% 87.80% -4.71%
==========================================
Files 78 78
Lines 4871 4871
==========================================
- Hits 4506 4277 -229
- Misses 365 594 +229
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nejch
reviewed
Feb 5, 2022
There are occasions where a GitLab `list()` call does not return the `x-per-page` header. For example the listing of custom attributes. Update the type-hints to reflect that.
b0deed9 to
e825653
Compare
I'm not sure how much value in testing for this, but I can if you want. |
nejch
approved these changes
Feb 5, 2022
Probably not :) just another weird one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are occasions where a GitLab
list()call does not return thex-per-pageheader. For example the listing of custom attributes.Update the type-hints to reflect that.