Skip to content

feat(merge_request_approvals): add support for deleting MR approval rules #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2022

Conversation

nejch
Copy link
Member

@nejch nejch commented Feb 10, 2022

Closes #1538.

@codecov-commenter
Copy link

Codecov Report

Merging #1888 (25a4518) into main (5beda3b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1888   +/-   ##
=======================================
  Coverage   92.52%   92.52%           
=======================================
  Files          78       78           
  Lines        4885     4885           
=======================================
  Hits         4520     4520           
  Misses        365      365           
Flag Coverage Δ
cli_func_v4 81.74% <100.00%> (ø)
py_func_v4 80.26% <100.00%> (ø)
unit 83.39% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/merge_request_approvals.py 90.58% <100.00%> (ø)

@JohnVillalovos JohnVillalovos merged commit 85a734f into main Feb 13, 2022
@JohnVillalovos JohnVillalovos deleted the feat/delete-mr-approval-rule branch February 13, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Deleting Merge Request Approval Rules
3 participants