Skip to content

fix(cli): changed default allow_abbrev value to fix arguments collision problem #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2022
Merged

fix(cli): changed default allow_abbrev value to fix arguments collision problem #2013

merged 1 commit into from
May 9, 2022

Conversation

JohnVillalovos
Copy link
Member

@JohnVillalovos JohnVillalovos commented May 8, 2022 •
edited
Loading 

The `--job` argument could be interpreted as `--job-token`

Example failure:

  $ gitlab \
    --private-token ${GITLAB_API_KEY} -o json \
    project-artifact download \
    --project-id mdm/entities \
    --job ${JOB} \
    --ref-name ${REF} \

  gitlab: error: argument --job-token: not allowed with argument
  --private-token

@JohnVillalovos JohnVillalovos force-pushed the jlvillal/fix-argparse-abbrev branch 2 times, most recently from 89482eb to f907c15 Compare May 9, 2022 15:25
@JohnVillalovos
Copy link
Member Author

@nejch This is the same as: #1957 but ran black and updated the commit message.

@JohnVillalovos JohnVillalovos requested a review from nejch May 9, 2022 15:27
@meteozond @JohnVillalovos
fix(cli): changed default allow_abbrev value to fix arguments colli…
25fc65a 
…sion problem

The `--job` argument could be interpreted as `--job-token`

Example failure:

  $ gitlab \
    --private-token ${GITLAB_API_KEY} -o json \
    project-artifact download \
    --project-id mdm/entities \
    --job ${JOB} \
    --ref-name ${REF} \

  gitlab: error: argument --job-token: not allowed with argument
  --private-token
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/fix-argparse-abbrev branch from f907c15 to 25fc65a Compare May 9, 2022 15:31
@JohnVillalovos JohnVillalovos changed the title fix(cli): changed default allow_abbrev value to fix arguments colli… fix(cli): changed default allow_abbrev value to fix arguments collision problem May 9, 2022
@nejch nejch mentioned this pull request May 9, 2022
Closed
@nejch
Copy link
Member

nejch commented May 9, 2022

Thanks again @meteozond for the fix and @JohnVillalovos for the green CI :)

@nejch nejch merged commit d68cacf into main May 9, 2022
@nejch nejch deleted the jlvillal/fix-argparse-abbrev branch May 9, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nejch nejch nejch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohnVillalovos @nejch @meteozond