Skip to content

docs: Update issue example and extend API usage #2022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2022
Merged

docs: Update issue example and extend API usage #2022

merged 1 commit into from
May 23, 2022

Conversation

MichaelSweikata
Copy link

Updates to the documentation to include changes on the Gitlab API for assignee_ids, and explicitly reference how to extend an object for attributes not explicitly mentioned.

JohnVillalovos
JohnVillalovos requested changes May 17, 2022
View reviewed changes
@JohnVillalovos
Copy link
Member

Looks good to me. Just one minor issue. Thanks!

@JohnVillalovos
Copy link
Member

@MichaelSweikata Looks good but can you squash the four commits down to one commit?

@MichaelSweikata
Copy link
Author

@MichaelSweikata Looks good but can you squash the four commits down to one commit?

I'll do my best to figure out how, sorry, still new at this part!

@JohnVillalovos
Copy link
Member

@MichaelSweikata Looks good but can you squash the four commits down to one commit?

I'll do my best to figure out how, sorry, still new at this part!

I found some info here. https://www.git-tower.com/learn/git/faq/git-squash/

But if you like I can try to squash them for you.

@nejch nejch force-pushed the feat/documentation-update branch from 331a931 to aad71d2 Compare May 23, 2022 22:10
@nejch
Copy link
Member

nejch commented May 23, 2022

As we already have a LGTM by @JohnVillalovos here I pushed a squashed commit instead of doing a new one in #2025 to keep the history here, hope that's ok with you both :)

@nejch nejch enabled auto-merge May 23, 2022 22:15
@nejch nejch merged commit 792cee9 into python-gitlab:main May 23, 2022
@JohnVillalovos
Copy link
Member

As we already have a LGTM by @JohnVillalovos here I pushed a squashed commit instead of doing a new one in #2025 to keep the history here, hope that's ok with you both :)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnVillalovos JohnVillalovos JohnVillalovos requested changes

@nejch nejch nejch approved these changes

Assignees

@MichaelSweikata MichaelSweikata

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MichaelSweikata @JohnVillalovos @nejch @msweikatacoco