Skip to content

chore: enable 'consider-using-sys-exit' pylint check #2050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2022

Conversation

JohnVillalovos
Copy link
Member

Enable the 'consider-using-sys-exit' pylint check and fix errors
raised.

Enable the 'consider-using-sys-exit' pylint check and fix errors
raised.
@codecov-commenter
Copy link

Codecov Report

Merging #2050 (0afcc3e) into main (00aec96) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2050   +/-   ##
=======================================
  Coverage   94.52%   94.52%           
=======================================
  Files          78       78           
  Lines        4972     4972           
=======================================
  Hits         4700     4700           
  Misses        272      272           
Flag Coverage Δ
cli_func_v4 82.54% <0.00%> (ø)
py_func_v4 80.99% <0.00%> (ø)
unit 85.47% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/cli.py 90.47% <0.00%> (ø)

Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, not sure why we weren't doing this already 😁

@nejch nejch merged commit 9ab3c10 into main Jun 4, 2022
@nejch nejch deleted the jlvillal/more_pylint branch June 4, 2022 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants