Skip to content

chore: enable more pylint checks #2051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 5, 2022
Merged

chore: enable more pylint checks #2051

merged 7 commits into from
Jun 5, 2022

Conversation

JohnVillalovos
Copy link
Member

No description provided.

@JohnVillalovos JohnVillalovos marked this pull request as draft June 3, 2022 23:49
Enable the pylint checks:
  * unnecessary-pass
  * unspecified-encoding

Update code to resolve errors found
Enabled the pylint checks that don't require any code changes.
Previously these checks were disabled.
Enable the pylint check "raise-missing-from" and fix errors detected.
Enable the pylint check: "attribute-defined-outside-init" and fix
errors detected.
Enable the pylint check "no-else-return" and fix the errors detected.
Enable the pylint check "no-self-use" and fix the errors detected.
Enable the pylint check "redefined-outer-name" and fix the errors
detected.
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/more_more_pylint branch from 7ca7a00 to 1324ce1 Compare June 4, 2022 16:18
@JohnVillalovos JohnVillalovos marked this pull request as ready for review June 4, 2022 16:28
@JohnVillalovos JohnVillalovos requested a review from nejch June 4, 2022 16:29
@JohnVillalovos
Copy link
Member Author

@nejch Let me know if you would prefer this split into multiple PRs.

@nejch
Copy link
Member

nejch commented Jun 5, 2022

@nejch Let me know if you would prefer this split into multiple PRs.

It's ok, LGTM! pylint complaining about attribute-defined-outside-init for rest objects IMO is a bit dubious in our case, as we already abuse instance attributes for API attributes. That will always be a moving target, but let's see :)

@nejch nejch changed the title Even more pylint... chore: enable more pylint checks Jun 5, 2022
@nejch nejch merged commit 7a5923c into main Jun 5, 2022
@nejch nejch deleted the jlvillal/more_more_pylint branch June 5, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants