Skip to content

chore: fix issue found with pylint==2.14.3 #2077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2022
Merged

chore: fix issue found with pylint==2.14.3 #2077

merged 1 commit into from
Jun 20, 2022

Conversation

JohnVillalovos
Copy link
Member

A new error was reported when running pylint==2.14.3:
gitlab/client.py:488:0: W1404: Implicit string concatenation found in call (implicit-str-concat)

Fixed this issue.

@JohnVillalovos JohnVillalovos requested a review from nejch June 20, 2022 02:18
A new error was reported when running pylint==2.14.3:
  gitlab/client.py:488:0: W1404: Implicit string concatenation found in call (implicit-str-concat)

Fixed this issue.
@codecov-commenter
Copy link

Codecov Report

Merging #2077 (eeab035) into main (f117b2f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2077   +/-   ##
=======================================
  Coverage   94.64%   94.64%           
=======================================
  Files          78       78           
  Lines        5003     5003           
=======================================
  Hits         4735     4735           
  Misses        268      268           
Flag Coverage Δ
cli_func_v4 82.45% <0.00%> (ø)
py_func_v4 81.03% <0.00%> (ø)
unit 85.60% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/client.py 98.67% <100.00%> (ø)

@nejch
Copy link
Member

nejch commented Jun 20, 2022

Thanks @JohnVillalovos! Looks like a leftover from black commits or so :)

@nejch nejch merged commit 8e0cd8b into main Jun 20, 2022
@nejch nejch deleted the jlvillal/pylint branch June 20, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants