Skip to content

chore(ci): increase timeout for docker container to come online #2089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

JohnVillalovos
Copy link
Member

Have been seeing timeout issues more and more. Increase timeout from
200 seconds to 300 seconds (5 minutes).

@nejch
Copy link
Member

nejch commented Jun 24, 2022

Thanks @JohnVillalovos!

What I've also been thinking is that sometimes the GitLab container completely fails to start up properly in underpowered CI VMs (I have a similar test setup on GitLab CI using services:).

If that still happens with 5 minutes, we might need to investigate further slimming down the services started in the Omnibus config. GitLab is quite a beast now with all the batteries-included stuff 🤔

@JohnVillalovos JohnVillalovos force-pushed the jlvillal/more_time branch 2 times, most recently from 7a8bba8 to 4d74e30 Compare June 24, 2022 15:02
Have been seeing timeout issues more and more. Increase timeout from
200 seconds to 300 seconds (5 minutes).
@codecov-commenter
Copy link

Codecov Report

Merging #2089 (bda020b) into main (f0ac3cd) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2089   +/-   ##
=======================================
  Coverage   94.69%   94.69%           
=======================================
  Files          78       78           
  Lines        5050     5056    +6     
=======================================
+ Hits         4782     4788    +6     
  Misses        268      268           
Flag Coverage Δ
cli_func_v4 82.55% <ø> (+0.02%) ⬆️
py_func_v4 81.15% <ø> (+0.02%) ⬆️
unit 85.75% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/const.py 100.00% <0.00%> (ø)
gitlab/__init__.py 100.00% <0.00%> (ø)
gitlab/exceptions.py 100.00% <0.00%> (ø)

@nejch nejch merged commit a825844 into main Jun 24, 2022
@nejch nejch deleted the jlvillal/more_time branch June 24, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants