test(pylint): enable pylint "unused-argument" check #2100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2100 +/- ##
=======================================
Coverage 94.73% 94.73%
=======================================
Files 78 78
Lines 5087 5087
=======================================
Hits 4819 4819
Misses 268 268
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nejch
requested changes
Jun 26, 2022
There was a problem hiding this comment.
Thanks @JohnVillalovos, just a few tiny comments mainly for always passing on kwargs as we claim in our docs that we support it for sudo (and maybe in a few cases would also be useful for pagination args).
Enable the pylint "unused-argument" check and resolve issues it found.
* Quite a few functions were accepting `**kwargs` but not then
passing them on through to the next level. Now pass `**kwargs` to
next level.
* Other functions had no reason to accept `**kwargs`, so remove it
* And a few other fixes.
665b2c8 to
23feae9
Compare
nejch
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the pylint "unused-argument" check and resolve issues it found.
**kwargsbut not thenpassing them on through to the next level. Now pass
**kwargstonext level.
**kwargs, so remove it