Skip to content

feat(client): mask tokens by default when logging #2101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

nejch
Copy link
Member

@nejch nejch commented Jun 26, 2022

Tiny step towards #2080

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2022

Codecov Report

Merging #2101 (144b36e) into main (45b8930) will increase coverage by 4.22%.
Report is 2 commits behind head on main.
The diff coverage is 93.54%.

@@            Coverage Diff             @@
##             main    #2101      +/-   ##
==========================================
+ Coverage   92.16%   96.38%   +4.22%     
==========================================
  Files          88       88              
  Lines        5708     5734      +26     
==========================================
+ Hits         5261     5527     +266     
+ Misses        447      207     -240     
Flag Coverage Δ
api_func_v4 82.35% <22.58%> (?)
cli_func_v4 83.46% <93.54%> (+0.23%) ⬆️
unit 88.00% <90.32%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
gitlab/client.py 98.58% <94.44%> (+2.32%) ⬆️
gitlab/utils.py 97.72% <92.30%> (+0.35%) ⬆️

... and 35 files with indirect coverage changes

@nejch nejch force-pushed the feat/logging-mask-tokens branch 2 times, most recently from 8d38920 to 08519b7 Compare July 29, 2022 21:38
@nejch
Copy link
Member Author

nejch commented Aug 6, 2022

Closing this to reduce the number of drafts open - I'll keep the branch and reopen when ready.

@nejch nejch closed this Aug 6, 2022
@nejch nejch reopened this Oct 12, 2023
@nejch nejch force-pushed the feat/logging-mask-tokens branch 2 times, most recently from 1cf62f8 to aeb9bf1 Compare October 12, 2023 14:04
@nejch nejch marked this pull request as ready for review October 12, 2023 14:18
@nejch nejch force-pushed the feat/logging-mask-tokens branch 2 times, most recently from 8b1de0b to 144b36e Compare October 12, 2023 14:42
@nejch
Copy link
Member Author

nejch commented Oct 12, 2023

Revived another old one that we could maybe squeeze in 🙇

the logging tests are a bit funny, had to use capsys because caplog does not support custom handlers out of the box. But kind of works.

@nejch nejch requested a review from JohnVillalovos October 12, 2023 14:45
@JohnVillalovos JohnVillalovos force-pushed the feat/logging-mask-tokens branch from 144b36e to 7d2a2bd Compare October 13, 2023 15:13
@JohnVillalovos JohnVillalovos enabled auto-merge (rebase) October 13, 2023 15:13
@JohnVillalovos JohnVillalovos merged commit 163bfcf into main Oct 13, 2023
@JohnVillalovos JohnVillalovos deleted the feat/logging-mask-tokens branch October 13, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants