Skip to content

feat(cli): add support for global CI lint #2128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 5, 2022
Merged

Conversation

nejch
Copy link
Member

@nejch nejch commented Jul 5, 2022

Built on top of #1896, does most of the prep work for #546.

@codecov-commenter
Copy link

Codecov Report

Merging #2128 (45e99eb) into main (1fbfb22) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2128      +/-   ##
==========================================
+ Coverage   95.36%   95.38%   +0.01%     
==========================================
  Files          78       79       +1     
  Lines        5113     5130      +17     
==========================================
+ Hits         4876     4893      +17     
  Misses        237      237              
Flag Coverage Δ
cli_func_v4 82.49% <92.30%> (+0.03%) ⬆️
py_func_v4 81.26% <96.15%> (+0.06%) ⬆️
unit 87.07% <96.15%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/client.py 98.69% <100.00%> (+<0.01%) ⬆️
gitlab/v4/objects/__init__.py 100.00% <100.00%> (ø)
gitlab/v4/objects/ci_lint.py 100.00% <100.00%> (ø)
gitlab/v4/objects/projects.py 100.00% <100.00%> (ø)

@nejch nejch marked this pull request as ready for review July 5, 2022 13:39
@JohnVillalovos JohnVillalovos merged commit d5de4b1 into main Jul 5, 2022
@JohnVillalovos JohnVillalovos deleted the feat/ci-lint-cli branch July 5, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants