Skip to content

feat: support validating CI lint results #2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2022
Merged

Conversation

nejch
Copy link
Member

@nejch nejch commented Jul 9, 2022

Closes #546.

There's a bit of duplication because of the inconsistent APIs between global/project endpoints.

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2022

Codecov Report

Merging #2134 (f3a53aa) into main (d5de4b1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2134      +/-   ##
==========================================
+ Coverage   95.38%   95.39%   +0.01%     
==========================================
  Files          79       79              
  Lines        5130     5150      +20     
==========================================
+ Hits         4893     4913      +20     
  Misses        237      237              
Flag Coverage Δ
cli_func_v4 82.60% <100.00%> (+0.10%) ⬆️
py_func_v4 81.10% <42.85%> (-0.17%) ⬇️
unit 87.00% <71.42%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/exceptions.py 100.00% <100.00%> (ø)
gitlab/v4/cli.py 90.74% <100.00%> (+0.13%) ⬆️
gitlab/v4/objects/ci_lint.py 100.00% <100.00%> (ø)

@nejch nejch force-pushed the feat/validate-ci-lint branch from b25ae52 to f3a53aa Compare July 9, 2022 12:25
@nejch nejch marked this pull request as ready for review July 9, 2022 12:26
Copy link
Member

@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Looks useful 😊

@JohnVillalovos JohnVillalovos merged commit 3b1ede4 into main Jul 9, 2022
@JohnVillalovos JohnVillalovos deleted the feat/validate-ci-lint branch July 9, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add lint feature to the cli
3 participants