Skip to content

chore: change name of API functional test to api_func_v4 #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
runs-on: ubuntu-20.04
strategy:
matrix:
toxenv: [py_func_v4, cli_func_v4]
toxenv: [api_func_v4, cli_func_v4]
steps:
- uses: actions/checkout@v3
- name: Set up Python
Expand Down
10 changes: 5 additions & 5 deletions CONTRIBUTING.rst
Original file line number Diff line number Diff line change
Expand Up @@ -89,15 +89,15 @@ To run these tests:
tox -e cli_func_v4

# run the python API tests:
tox -e py_func_v4
tox -e api_func_v4

When developing tests it can be a little frustrating to wait for GitLab to spin
up every run. To prevent the containers from being cleaned up afterwards, pass
`--keep-containers` to pytest, i.e.:

.. code-block:: bash

tox -e py_func_v4 -- --keep-containers
tox -e api_func_v4 -- --keep-containers

If you then wish to test against a clean slate, you may perform a manual clean
up of the containers by running:
Expand All @@ -117,11 +117,11 @@ The tag must match an exact tag on Docker Hub:
.. code-block:: bash

# run tests against `nightly` or specific tag
GITLAB_TAG=nightly tox -e py_func_v4
GITLAB_TAG=12.8.0-ce.0 tox -e py_func_v4
GITLAB_TAG=nightly tox -e api_func_v4
GITLAB_TAG=12.8.0-ce.0 tox -e api_func_v4

# run tests against the latest gitlab EE image
GITLAB_IMAGE=gitlab/gitlab-ee tox -e py_func_v4
GITLAB_IMAGE=gitlab/gitlab-ee tox -e api_func_v4

A freshly configured gitlab container will be available at
http://localhost:8080 (login ``root`` / password ``5iveL!fe``). A configuration
Expand Down
2 changes: 1 addition & 1 deletion codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ coverage:
range: "70...100"

comment:
after_n_builds: 3 # coverage, py_func_v4, py_func_cli
after_n_builds: 3 # coverage, api_func_v4, py_func_cli
layout: "diff,flags,files"
behavior: default
require_changes: yes
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ deps = -r{toxinidir}/requirements-docker.txt
commands =
pytest --script-launch-mode=subprocess --cov --cov-report xml tests/functional/cli {posargs}

[testenv:py_func_v4]
[testenv:api_func_v4]
deps = -r{toxinidir}/requirements-docker.txt
commands =
pytest --cov --cov-report xml tests/functional/api {posargs}
Expand Down