Skip to content

chore: enable mypy check warn_return_any #2157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Conversation

JohnVillalovos
Copy link
Member

Update code so that the warn_return_any check passes.

@JohnVillalovos JohnVillalovos force-pushed the jlvillal/mypy_step_by_step branch 5 times, most recently from 1dee87b to 656817c Compare July 22, 2022 15:05
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2022

Codecov Report

Merging #2157 (76ec4b4) into main (8ba97aa) will increase coverage by 3.99%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main    #2157      +/-   ##
==========================================
+ Coverage   91.56%   95.55%   +3.99%     
==========================================
  Files          81       81              
  Lines        5344     5351       +7     
==========================================
+ Hits         4893     5113     +220     
+ Misses        451      238     -213     
Flag Coverage Δ
api_func_v4 81.40% <75.00%> (?)
cli_func_v4 83.04% <75.00%> (-0.11%) ⬇️
unit 87.31% <87.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/mixins.py 92.05% <0.00%> (+5.24%) ⬆️
gitlab/base.py 99.50% <100.00%> (+<0.01%) ⬆️
gitlab/cli.py 100.00% <100.00%> (ø)
gitlab/client.py 98.71% <100.00%> (+3.44%) ⬆️
gitlab/utils.py 98.59% <0.00%> (+1.40%) ⬆️
gitlab/v4/objects/members.py 94.82% <0.00%> (+1.72%) ⬆️
gitlab/types.py 98.21% <0.00%> (+3.57%) ⬆️
gitlab/v4/objects/notes.py 94.28% <0.00%> (+3.80%) ⬆️
gitlab/v4/objects/groups.py 89.40% <0.00%> (+3.97%) ⬆️
... and 25 more

@JohnVillalovos JohnVillalovos force-pushed the jlvillal/mypy_step_by_step branch 2 times, most recently from a46d9bf to f33b902 Compare July 23, 2022 17:17
Update code so that the `warn_return_any` check passes.
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/mypy_step_by_step branch from f33b902 to 76ec4b4 Compare July 29, 2022 04:40
@JohnVillalovos JohnVillalovos requested a review from nejch July 29, 2022 04:45
@nejch nejch merged commit b8be32a into main Jul 29, 2022
@nejch nejch deleted the jlvillal/mypy_step_by_step branch July 29, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants