Skip to content

test: always ensure clean config environment #2187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2022
Merged

test: always ensure clean config environment #2187

merged 1 commit into from
Jul 26, 2022

Conversation

nejch
Copy link
Member

@nejch nejch commented Jul 26, 2022

Closes #2177

nejch
nejch commented Jul 26, 2022
View reviewed changes
JohnVillalovos
JohnVillalovos reviewed Jul 26, 2022
View reviewed changes
Copy link
Member

@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Left one question for something I didn't understand.

@nejch nejch force-pushed the test/clean-config branch from 3327cb6 to 7b5a282 Compare July 26, 2022 14:40
@nejch nejch force-pushed the test/clean-config branch from 2070d5f to 920c443 Compare July 26, 2022 16:56
@codecov-commenter
Copy link

Codecov Report

Merging #2187 (920c443) into main (4b798fc) will increase coverage by 4.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2187      +/-   ##
==========================================
+ Coverage   91.47%   95.52%   +4.04%     
==========================================
  Files          80       80              
  Lines        5268     5268              
==========================================
+ Hits         4819     5032     +213     
+ Misses        449      236     -213
Flag Coverage Δ
api_func_v4 81.37% <ø> (?)
cli_func_v4 83.02% <ø> (ø)
unit 87.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/utils.py 100.00% <0.00%> (+1.61%) ⬆️
gitlab/v4/objects/members.py 94.82% <0.00%> (+1.72%) ⬆️
gitlab/types.py 98.07% <0.00%> (+1.92%) ⬆️
gitlab/client.py 98.70% <0.00%> (+3.44%) ⬆️
gitlab/v4/objects/notes.py 94.28% <0.00%> (+3.80%) ⬆️
gitlab/v4/objects/groups.py 89.18% <0.00%> (+4.05%) ⬆️
gitlab/v4/objects/pages.py 100.00% <0.00%> (+5.00%) ⬆️
gitlab/v4/objects/events.py 98.73% <0.00%> (+5.06%) ⬆️
gitlab/mixins.py 92.30% <0.00%> (+5.49%) ⬆️
gitlab/v4/objects/users.py 96.38% <0.00%> (+6.02%) ⬆️
... and 21 more

@nejch nejch requested a review from JohnVillalovos July 26, 2022 17:09
@JohnVillalovos JohnVillalovos merged commit 8d4f13b into main Jul 26, 2022
@JohnVillalovos JohnVillalovos deleted the test/clean-config branch July 26, 2022 23:03
@JohnVillalovos
Copy link
Member

Thanks @nejch !

@nejch nejch mentioned this pull request Jul 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnVillalovos JohnVillalovos JohnVillalovos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make tests so that will not be impacted by any existing config files
3 participants
@nejch @codecov-commenter @JohnVillalovos