Support downloading archive subpaths #2199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnVillalovos
requested changes
Jul 28, 2022
JohnVillalovos
approved these changes
Jul 28, 2022
|
@orf Thanks for the contribution! |
JohnVillalovos
requested changes
Jul 28, 2022
|
@JohnVillalovos for later: we could potentially also prefix these internal python-gitlab variables in the mixins and custom methods to always avoid clashes with GitLab API attributes. So this would be @orf sometimes our variables happen to overlap with upstream API attributes hence the suggestion. diff --git a/gitlab/v4/objects/repositories.py b/gitlab/v4/objects/repositories.py
index 8f99e5d..b8dbdd8 100644
--- a/gitlab/v4/objects/repositories.py
+++ b/gitlab/v4/objects/repositories.py
@@ -229,16 +229,16 @@ class RepositoryMixin(_RestObjectBase):
Returns:
The binary data of the archive
"""
- path = f"/projects/{self.encoded_id}/repository/archive"
+ url_path = f"/projects/{self.encoded_id}/repository/archive"
if format:
- path += "." + format
+ url_path += "." + format
query_data = {}
if sha:
query_data["sha"] = sha
if path is not None:
query_data["path"] = path
result = self.manager.gitlab.http_get(
- path, query_data=query_data, raw=True, streamed=streamed, **kwargs
+ url_path, query_data=query_data, raw=True, streamed=streamed, **kwargs
)
if TYPE_CHECKING:
assert isinstance(result, requests.Response) |
|
Thank you both! I've applied your suggestions 🙏 |
nejch
approved these changes
Jul 29, 2022
|
I guess we can get this one in, I hope you don't mind @JohnVillalovos ;) @orf thanks again! I think I recognized your username from the loguru saga, fun popcorn material. :) |
Thanks for reviewing it @nejch ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.gitlab.com/ee/api/repositories.html#get-file-archive
The archive endpoint supports a
pathargument. This change adds support for it.