Skip to content

feat(client): warn user on misconfigured URL in auth() #2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 4, 2022
Merged

feat(client): warn user on misconfigured URL in auth() #2222

merged 3 commits into from
Aug 4, 2022

Conversation

nejch
Copy link
Member

@nejch nejch commented Aug 4, 2022 •
edited
Loading

Closes #1978.

3 steps here:

  • 7b61ae6 removes a hack to handle gitlab's non-standard headers. That was only valid for 13.0 and fixed in 13.1 - super old now and I wouldn't say we're expected to support that.
  • 31c9c2f refactors the nested code out into a slightly more generic helper (that's where it should live anyway, as most of the attributes are from the Gitlab instance)
  • d71c1db adds it to auth() so the user gets a warning ASAP.

Other than that I haven't changed any of the str/None handling to keep the next_url code the same in _query.

@nejch nejch force-pushed the feat/warn-user-misconfigured-url branch from 6f5b0e7 to d71c1db Compare August 4, 2022 16:21
@nejch nejch marked this pull request as ready for review August 4, 2022 16:22
@nejch nejch requested a review from JohnVillalovos August 4, 2022 16:24
JohnVillalovos
JohnVillalovos approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @nejch

@JohnVillalovos JohnVillalovos merged commit 0040b43 into main Aug 4, 2022
@JohnVillalovos JohnVillalovos deleted the feat/warn-user-misconfigured-url branch August 4, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnVillalovos JohnVillalovos JohnVillalovos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warn user when detecting misconfigured server external_url?
2 participants
@nejch @JohnVillalovos