Skip to content

feat: add support for deployment approval endpoint #2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2022

Conversation

JohnVillalovos
Copy link
Member

Add support for the deployment approval endpoint[1]

[1] https://docs.gitlab.com/ee/api/deployments.html#approve-or-reject-a-blocked-deployment
Closes: #2253

@JohnVillalovos JohnVillalovos requested a review from nejch August 24, 2022 03:59
Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM! Just a quick question mostly about upstream API weirdness.

@JohnVillalovos JohnVillalovos force-pushed the jlvillal/deploy_approve branch from 9f9e25b to 9c9eeb9 Compare August 25, 2022 14:57
@codecov-commenter
Copy link

Codecov Report

Merging #2254 (9c9eeb9) into main (e095735) will increase coverage by 8.18%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main    #2254      +/-   ##
==========================================
+ Coverage   87.23%   95.41%   +8.18%     
==========================================
  Files          81       81              
  Lines        5375     5390      +15     
==========================================
+ Hits         4689     5143     +454     
+ Misses        686      247     -439     
Flag Coverage Δ
api_func_v4 81.29% <50.00%> (?)
cli_func_v4 82.83% <50.00%> (?)
unit 87.23% <87.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/deployments.py 93.10% <85.71%> (-6.90%) ⬇️
gitlab/exceptions.py 100.00% <100.00%> (ø)
gitlab/config.py 100.00% <0.00%> (+1.12%) ⬆️
gitlab/utils.py 98.59% <0.00%> (+1.40%) ⬆️
gitlab/v4/objects/members.py 94.82% <0.00%> (+1.72%) ⬆️
gitlab/v4/objects/export_import.py 94.73% <0.00%> (+2.63%) ⬆️
gitlab/types.py 98.21% <0.00%> (+3.57%) ⬆️
gitlab/v4/objects/notes.py 94.28% <0.00%> (+3.80%) ⬆️
gitlab/v4/objects/groups.py 89.40% <0.00%> (+3.97%) ⬆️
gitlab/v4/objects/jobs.py 78.26% <0.00%> (+4.34%) ⬆️
... and 31 more

@nejch nejch merged commit 56fbe02 into main Aug 28, 2022
@nejch nejch deleted the jlvillal/deploy_approve branch August 28, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: Support deployment approve/reject
3 participants