Skip to content

Conversation

mondwan
Copy link
Contributor

@mondwan mondwan commented Mar 17, 2017

  • Integrate with BaseManager
  • Add doc about how to create a pipeline

Reference:

* Integrate with BaseManager
* Add doc about how to create a pipeline

Reference:
* https://docs.gitlab.com/ee/api/pipelines.html#create-a-new-pipeline
@mondwan
Copy link
Contributor Author

mondwan commented Mar 17, 2017

Notes: I am not able to run tox with py27 and py34 by default.

Copy link
Contributor

@gpocentek gpocentek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a nitpick in the docs the patch looks good. If you could just do the minor update, I'll merge your change.

Thank you!

# pipeline create
pipeline = gl.project_pipelines.create({'project_id': 1, 'ref': 'master'})
# or
project.pipelines.create({'ref': 'master'})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you just do a minor edit for consistency:

pipeline = project.pipelines.create({'ref': 'master'})

@mondwan
Copy link
Contributor Author

mondwan commented Mar 17, 2017

Sure. I have updated the document as requested

@gpocentek gpocentek merged commit 8c27e70 into python-gitlab:master Mar 18, 2017
@gpocentek
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants