chore: add a UserWarning if both iterator=True and page=X are used
#2462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8aed6c8 to
7159747
Compare
iteratore=True and page=Xiterator=True and page=X
iterator=True and page=Xiterator=True and page=X are used
nejch
reviewed
Jan 26, 2023
There was a problem hiding this comment.
Thanks @JohnVillalovos just a little typo there!
Hopefully we can remove as_list for a major bump at some point and simplify these checks 😁
If a caller calls a `list()` method with both `iterator=True` (or `as_list=False`) and `page=X` then emit a `UserWarning` as the options are mutually exclusive.
7159747 to
bec4f6a
Compare
nejch
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a caller calls a
list()method with bothiterator=True(oras_list=False) andpage=Xthen emit aUserWarningas the options are mutually exclusive.